Skip to content

fix(@angular-devkit/build-angular): fix issue were @media all causi… #21321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
filipesilva merged 1 commit into from
Jul 12, 2021
Merged

fix(@angular-devkit/build-angular): fix issue were @media all causi… #21321

filipesilva merged 1 commit into from
Jul 12, 2021

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jul 9, 2021 •
edited
Loading

Cherry pick of #21306

@alan-agius4
fix(@angular-devkit/build-angular): fix issue were @media all causi…
567d6e2 
…ng critical CSS inling to fail

Workaround for Critters as it doesn't work when `@media all {}` is minified to `@media {}`.

Closes #20804

(cherry picked from commit 3d71c63)
@google-cla google-cla bot added the cla: yes label Jul 9, 2021
@alan-agius4 alan-agius4 requested a review from filipesilva July 9, 2021 16:11
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 9, 2021
@filipesilva filipesilva added the action: merge The PR is ready for merge by the caretaker label Jul 9, 2021
@filipesilva filipesilva merged commit c21f650 into angular:12.1.x Jul 12, 2021
@alan-agius4 alan-agius4 deleted the cherry-21306 branch July 12, 2021 15:52
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 12, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@filipesilva filipesilva filipesilva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@filipesilva filipesilva

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-agius4 @filipesilva